Skip to content

Stable fallback to previously shown process - #2090

Merged
BenBE merged 2 commits into
htop-dev:mainfrom
fasterit:stable-fallback-to-previously-shown-process
Sep 11, 2026
Merged

Stable fallback to previously shown process#2090
BenBE merged 2 commits into
htop-dev:mainfrom
fasterit:stable-fallback-to-previously-shown-process

Conversation

@fasterit

Copy link
Copy Markdown
Member

Applies on top of the header-meter-clicks branch (PR #2085)

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 02cac0f0-c944-4808-a164-4fbd132ed84f

📥 Commits

Reviewing files that changed from the base of the PR and between f530113 and 17eb297.

📒 Files selected for processing (1)
  • Table.c

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The PR adds span-aware integer header dimensions and header meter hit-testing. It adds click callbacks to meters and forwards header mouse clicks through ScreenManager. The Tasks meter toggles thread visibility from text-mode count clicks. Table selection state is preserved and restored across visibility-driven rescans. Existing toggle actions also preserve selection before rescanning.

Priority: ⬇️ Low

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 17eb2

The selection-preservation and header-click changes have no remaining concrete merge-blocking risk.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Columns find their measured place
A click now follows a precise trace
Thread counts turn their setting bright
Rows return through rebuild night
Selections stay where they belong

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: cafe07af-fea9-41a4-8170-abd5b2c3cc1f

📥 Commits

Reviewing files that changed from the base of the PR and between 19fc8c1 and f310163.

📒 Files selected for processing (9)
  • Action.c
  • Header.c
  • Header.h
  • HeaderLayout.h
  • Meter.h
  • ScreenManager.c
  • Table.c
  • Table.h
  • TasksMeter.c

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.

Comment thread ScreenManager.c Outdated
@BenBE

BenBE commented Sep 11, 2026

Copy link
Copy Markdown
Member

@fasterit This branch needs a rebase before merge.

Daniel Lange added 2 commits September 11, 2026 15:01
…hreads / container visibility

Applies on top of the header-meter-clicks branch (PR htop-dev#2085)

Assisted-by: OpenCode Zen
@fasterit
fasterit force-pushed the stable-fallback-to-previously-shown-process branch from f530113 to 17eb297 Compare September 11, 2026 15:09
@fasterit

Copy link
Copy Markdown
Member Author

@fasterit This branch needs a rebase before merge.

done

@BenBE
BenBE merged commit c83c657 into htop-dev:main Sep 11, 2026
21 checks passed
@fasterit fasterit added this to the 3.6.0 milestone Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants