Install fish shell completions via pip#1899
Open
yoshibase wants to merge 1 commit into
Open
Conversation
yoshibase
force-pushed
the
fix/issue-912-fish-completions
branch
3 times, most recently
from
July 25, 2026 04:11
a96871e to
4484e2e
Compare
Install a command-named Fish loader alongside the canonical completion definitions without duplicating the completion script. Fixes httpie#912
yoshibase
force-pushed
the
fix/issue-912-fish-completions
branch
from
July 25, 2026 04:18
4484e2e to
1a5b3e5
Compare
Author
|
CI note after the clean rebuild: the current PR is only the 3 packaging/completion files, and the wheel + sdist build succeeds with both Fish files in The remaining red jobs reproduce on upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #912.
Install HTTPie's existing Fish completions through Python wheels and source distributions, so Fish discovers completions for the
httpcommand without downstream package-specific copying.Changes
share/fish/vendor_completions.dtosetup.cfgdata filesextras/httpie-completion.fishunchangedhttp.fishloader that sources the canonical definitions, avoiding a duplicated completion scriptTest plan
python -m build --sdist --wheelshare/fish/vendor_completions.d/http.fishshare/fish/vendor_completions.d/httpie-completion.fish