feat(desktop): bundle httui-lsp language server in the release#78
Merged
Conversation
gandarfh
force-pushed
the
feat/bundle-lsp
branch
2 times, most recently
from
June 11, 2026 00:51
34e45a5 to
c25708c
Compare
gandarfh
force-pushed
the
feat/bundle-lsp
branch
from
June 11, 2026 01:03
c25708c to
85f4f6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ships the
httui-lsplanguage server in the desktop bundle so installed apps (cask/.deb/.rpm) get diagnostics, typed hovers and field completion — until now the server only existed through a dev symlink.prepare-bundle-bins.shstageshttui-lsp-<triple>: fromHTTUI_LSP_BUNDLE_BIN(local builds) or downloaded from the pinnedhttuicom/httui-langrelease (v0.1.0). Hard failure on a missing asset; Windows targets skip the server (the desktop degrades gracefully without it —tauri.windows.conf.jsondrops it fromexternalBin).lsp_sidecarresolution:HTTUI_LSP_BIN→ bundled sibling next to the executable (release builds only — debug keeps resolving through PATH so dev never picks up a stale staged copy) → PATH.make buildfix: with twonpm runlayers the inner npm swallowed--bundles, so tauri receivedbuild app.Validation
Local end-to-end on macOS arm64: download path exercised by
make build,httui.app/Contents/MacOS/httui-lsppresent and answering the initialize handshake, and the app installed in /Applications spawns the bundled binary (/Applications/httui.app/Contents/MacOS/httui-lsp --db …). 112 tests in the tauri crate (sibling resolution covered), clippy, actionlint and shellcheck green.