Skip to content

refactor(desktop): ref hover and completion served by the lsp#82

Merged
gandarfh merged 1 commit into
mainfrom
refactor/server-refs
Jun 11, 2026
Merged

refactor(desktop): ref hover and completion served by the lsp#82
gandarfh merged 1 commit into
mainfrom
refactor/server-refs

Conversation

@gandarfh

Copy link
Copy Markdown
Member

Retires the local {{ref}} hover tooltip and completion sources in the markdown editor — the language server now has full parity (types, last-run values, $prev, numeric segments). Kills the stacked double tooltip.

  • The editor autocompletion override replaces ALL sources, which had silenced the server source since the first integration — serverCompletionSource is now in the override list (null-safe without the LSP plugin).
  • Dead code removed (-444 lines): markdown hover tooltips, per-block ref completion wrappers, the generic ref source.
  • Kept local on purpose: DB schema-aware SQL completion, the {{ref}} visual highlight (now directly tested), the click popover, and cm-autocomplete (consumed by the HTTP form-mode inline editors, outside the document the server sees).

Validated manually by the owner: single server tooltip with type + last value, alias/env/field/$prev. completion, DB SQL completion intact.

@gandarfh
gandarfh force-pushed the refactor/server-refs branch from 493b15f to f906723 Compare June 11, 2026 12:31
@gandarfh
gandarfh merged commit 7549d16 into main Jun 11, 2026
5 checks passed
@gandarfh
gandarfh deleted the refactor/server-refs branch June 11, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant