Close and unregister plugin classloader when load fails#57
Merged
huangdihd merged 2 commits intoJun 1, 2026
Merged
Conversation
Not up to standards ⛔
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a plugin fails to load during
Class.forName/newInstance(e.g. a badmainclass, an exception in the plugin constructor), thePluginClassLoaderhad already been registered inpluginLoaders(and the dependency list inpluginDependencies) before instantiation was attempted. On failure the exception propagated out without closing the classloader or removing the map entries, leaking the open jar file handle. On Windows this surfaces as "file is in use" when reloading the plugin.Changes
PluginManager.loadPlugin(File)andinstantiateAndLoad: wrap theClass.forName/newInstancein try/catch; on failure remove thepluginLoadersandpluginDependenciesentries,close()the classloader, then rethrow.PluginClassloaderLeakTest: loads a jar whoseplugin.ymlis valid but whosemainpoints to a non-existent class, asserts the load throws and that no classloader / dependency entry lingers afterwards.maven-test.yml.No behavior change on the successful-load path.