This repository was archived by the owner on Aug 31, 2021. It is now read-only.
support rename of rds instance #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1098
💛 - Coveralls |
ShiChangkuo
reviewed
Jan 29, 2021
openstack/rds/v3/instances/urls.go
Outdated
Comment on lines
25
to
28
| func renameURL(c *golangsdk.ServiceClient, instancesId string) string { | ||
| return c.ServiceURL("instances", instancesId, "name") | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
we can define a common function named updateURL which has tree parameters: c *golangsdk.ServiceClient, instancesId string and updata string
| return b, nil | ||
| } | ||
|
|
||
| func Rename(client *golangsdk.ServiceClient, opts RenameRdsInstanceBuilder, instanceId string) error { |
Collaborator
There was a problem hiding this comment.
suggest set the return value to commonResult
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Huaweicloud API support rename instance, we need to support rename function in Huaweicloud sdk.
Which issue this PR fixes:
Special notes for your reviewer:
Release note: