Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Conversation

@Lance52259
Copy link
Contributor

What this PR does / why we need it:

  1. Rds instance need support fixed_ip for code refactor.
  2. Error return of rename function isn't compliance with design specifications.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):
reference: #383

Special notes for your reviewer:

Release note:

1. new fixed_ip parameter.
2. new RenameResult struct and extract.
3. update error return of rename function form golangsdk.Result to RenameResult.

@coveralls
Copy link

coveralls commented Mar 23, 2021

Pull Request Test Coverage Report for Build 1204

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.171%

Totals Coverage Status
Change from base Build 1203: 0.0%
Covered Lines: 11559
Relevant Lines: 16956

💛 - Coveralls

@Lance52259 Lance52259 force-pushed the br_refactor_rds_instance_active branch from a5cf650 to e6d604f Compare March 23, 2021 03:39
@Lance52259 Lance52259 force-pushed the br_refactor_rds_instance_active branch from e6d604f to 94c12dd Compare March 23, 2021 07:29
@ShiChangkuo ShiChangkuo merged commit 4dc8674 into huaweicloud:master Mar 23, 2021
@Lance52259 Lance52259 deleted the br_refactor_rds_instance_active branch April 2, 2021 09:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants