Make Jacoco work on java 11 #1065
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
approved these changes
Mar 26, 2021
Contributor
gsmet
left a comment
gsmet
left a comment
There was a problem hiding this comment.
I thought it was needed for 11, just not required but if it causes issues, you can just make it 16+ (16 included).
Member
Author
|
@gsmet |
Member
Author
|
@gsmet Yup, looks like it isn't actually running on 16. Could you take a look and see if you can fix it. I only ask because you made the change and you probably know most about it. |
Contributor
|
I think you can close this one as #1079 should fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It appears that the change to unblock jacoco on Java 16+ broke jacoco on Java 11. I noticed this because running
mvn -Denable-ci install site" on Java 11 does not produce the jacoco report in thetarget/site` folder. Java 8 works., but I want to use Java 11 for releases, including site generation.@gsmet Any thoughts on this?