Fix JaCoCo execution when we have additional Surefire options #1079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typically on Java 16.
gsmet
commented
Apr 5, 2021
| <configuration> | ||
| <excludesFile>src/test/resources/slow-or-flaky-tests.txt</excludesFile> | ||
| <argLine>${surefire.argLine}</argLine> | ||
| <argLine>@{jacoco.surefire.argLine} ${surefire.argLine}</argLine> |
Contributor
Author
There was a problem hiding this comment.
To explain what happened: we are setting our own arg line now and, if set, the JaCoCo agent doesn't inject its options.
The change injects again the JaCoCo options.
`enable-ci` doesn't make sense with `skipTests`. The point of this job is get quick results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically on Java 16.
Note that the build then fails with Javadoc warnings. Apparently, the Java 16
javadocis a bit stricter. Not sure if we want to disable it for Java 16 for now or if someone wants to fix them (but there are a bunch of them and that would mean documenting very obvious stuff).