Derek furst/remove image file - #1030
Conversation
…ple-organ-other completely removed all uses of sample.other_organ
…er they occurred including api schema yamls and examples
yuanzhou
left a comment
yuanzhou
left a comment
There was a problem hiding this comment.
@DerekFurstPitt Other than removing these fields from the yaml files, there are also underlying methods in schema_triggers and schema_manager which we don't have to delete. For tracking purposes, can you add some comments to those methods to indicate they are no longer being used?
| # The updated_peripherally tag is a temporary measure to correctly handle any attributes | ||
| # which are potentially updated by multiple triggers | ||
| updated_peripherally: true | ||
| image_files_to_add: |
There was a problem hiding this comment.
Also remove image_files_to_add and image_files_to_remove from the schema yaml. They work together for the image file upload and commit/delete.
| # The updated_peripherally tag is a temporary measure to correctly handle any attributes | ||
| # which are potentially updated by multiple triggers | ||
| updated_peripherally: true | ||
| image_files_to_add: |
There was a problem hiding this comment.
Same as previous comment, also remove image_files_to_add and image_files_to_remove from the schema yaml.
| # The updated_peripherally tag is a temporary measure to correctly handle any attributes | ||
| # which are potentially updated by multiple triggers | ||
| updated_peripherally: true | ||
| metadata_files_to_add: |
There was a problem hiding this comment.
In a similar fashion, remove metadata_files_to_add and metadata_files_to_remove too.
There was a problem hiding this comment.
Addressed this with my latest update, let me know if there's any further changes requested or anything I missed
…e unused functions in schema_triggers relating to metadata_files and images_files but preserving their original uses for record keeping
2 participants
No description provided.