Skip to content

fix: remove empty sparkle:edSignature#44

Merged
hubo1989 merged 1 commit into
mainfrom
feat/v1.3.0
Feb 27, 2026
Merged

fix: remove empty sparkle:edSignature#44
hubo1989 merged 1 commit into
mainfrom
feat/v1.3.0

Conversation

@hubo1989
Copy link
Copy Markdown
Owner

@hubo1989 hubo1989 commented Feb 27, 2026

Remove empty sparkle:edSignature attribute from appcast.xml to fix update verification error.

Bump version to 1.3.4 (build 9).

Summary by CodeRabbit

发布说明

  • Chores
    • 应用版本升级至 1.3.4,内部编译号升至 9
    • 优化应用自动更新和发布流程,改进版本信息管理和更新发布机制

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 27, 2026

Warning

Rate limit exceeded

@hubo1989 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 20 minutes and 7 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between b853e2c and cc93917.

📒 Files selected for processing (2)
  • .github/workflows/release.yml
  • ScreenTranslate.xcodeproj/project.pbxproj
📝 Walkthrough

Walkthrough

该拉取请求更新了发布工作流和项目版本号。在 GitHub Actions 工作流中添加了构建号提取步骤,并将其集成到 Sparkle 应用检查中。同时将项目版本从 1.3.2 更新至 1.3.4,构建号从 7 更新至 9。

Changes

队列 / 文件 摘要
发布工作流配置
.github/workflows/release.yml
添加了从 project.pbxproj 解析构建号的新步骤,并将该构建号传递给 Sparkle Appcast 生成过程,用于替代标签派生的版本号。同时为 Appcast 项添加了描述性 CDATA 元素。
项目版本号更新
ScreenTranslate.xcodeproj/project.pbxproj
在四个 XCBuildSettings 块中将 CURRENT_PROJECT_VERSION 从 7 升级至 9,将 MARKETING_VERSION 从 1.3.2 升级至 1.3.4,涵盖 Debug/Release 配置和项目/目标级别的构建设置。

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • hubo1989/ScreenTranslate#18:同样修改了 ScreenTranslate.xcodeproj/project.pbxproj 中的构建和版本设置(CURRENT_PROJECT_VERSION 和 MARKETING_VERSION)。

Poem

🐰 版本跳跃从七到九,
Appcast 检查焕然一新,
构建号解析自动流,
发布流程更顺畅真,
兔子欢呼庆升级!✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning PR标题声称移除空的sparkle:edSignature属性,但原始摘要显示的主要变更是引入新的构建号提取步骤、更新Sparkle Appcast生成和版本号碰撞。 建议将标题改为更准确地反映主要变更,如'feat: update build number extraction and version bumping to 1.3.4'或类似的标题。
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/v1.3.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

- Remove empty sparkle:edSignature attribute from appcast.xml
- Bump version to 1.3.4 (build 9)

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/release.yml (1)

68-73: 构建号提取逻辑可行,但可以考虑增加健壮性。

当前的 grep -m1 方法能够正常工作,但如果 pbxproj 文件格式发生变化或包含注释中的 CURRENT_PROJECT_VERSION,可能会提取到错误的值。

♻️ 可选:使用更精确的模式匹配
       - name: Get Build Number
         id: build_number
         run: |
           # Extract build number from project
-          BUILD_NUM=$(grep -m1 'CURRENT_PROJECT_VERSION' ScreenTranslate.xcodeproj/project.pbxproj | sed 's/.*= *//;s/;//' | tr -d ' ')
+          BUILD_NUM=$(grep -E '^\s*CURRENT_PROJECT_VERSION\s*=' ScreenTranslate.xcodeproj/project.pbxproj | head -1 | sed 's/.*= *//;s/;//' | tr -d ' ')
           echo "build_num=$BUILD_NUM" >> $GITHUB_OUTPUT
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/release.yml around lines 68 - 73, The current build number
extraction in the build_number job uses a fragile grep -m1 for
CURRENT_PROJECT_VERSION which can pick up commented or unrelated occurrences;
update the BUILD_NUM extraction to match only the assignment line and ignore
comments (e.g., restrict the pattern to lines where CURRENT_PROJECT_VERSION
appears as a key, not inside comments, or anchor to the left of the line),
replace the existing grep/sed pipeline that sets BUILD_NUM with a more precise
shell pipeline (still writing the result to $GITHUB_OUTPUT as build_num) so it
only captures the actual CURRENT_PROJECT_VERSION assignment and fails noisily if
none is found.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/release.yml:
- Around line 68-73: The current build number extraction in the build_number job
uses a fragile grep -m1 for CURRENT_PROJECT_VERSION which can pick up commented
or unrelated occurrences; update the BUILD_NUM extraction to match only the
assignment line and ignore comments (e.g., restrict the pattern to lines where
CURRENT_PROJECT_VERSION appears as a key, not inside comments, or anchor to the
left of the line), replace the existing grep/sed pipeline that sets BUILD_NUM
with a more precise shell pipeline (still writing the result to $GITHUB_OUTPUT
as build_num) so it only captures the actual CURRENT_PROJECT_VERSION assignment
and fails noisily if none is found.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 94d94a9 and b853e2c.

📒 Files selected for processing (2)
  • .github/workflows/release.yml
  • ScreenTranslate.xcodeproj/project.pbxproj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant