fix: remove empty sparkle:edSignature#44
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough该拉取请求更新了发布工作流和项目版本号。在 GitHub Actions 工作流中添加了构建号提取步骤,并将其集成到 Sparkle 应用检查中。同时将项目版本从 1.3.2 更新至 1.3.4,构建号从 7 更新至 9。 Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Remove empty sparkle:edSignature attribute from appcast.xml - Bump version to 1.3.4 (build 9) Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
b853e2c to
cc93917
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/release.yml (1)
68-73: 构建号提取逻辑可行,但可以考虑增加健壮性。当前的
grep -m1方法能够正常工作,但如果 pbxproj 文件格式发生变化或包含注释中的CURRENT_PROJECT_VERSION,可能会提取到错误的值。♻️ 可选:使用更精确的模式匹配
- name: Get Build Number id: build_number run: | # Extract build number from project - BUILD_NUM=$(grep -m1 'CURRENT_PROJECT_VERSION' ScreenTranslate.xcodeproj/project.pbxproj | sed 's/.*= *//;s/;//' | tr -d ' ') + BUILD_NUM=$(grep -E '^\s*CURRENT_PROJECT_VERSION\s*=' ScreenTranslate.xcodeproj/project.pbxproj | head -1 | sed 's/.*= *//;s/;//' | tr -d ' ') echo "build_num=$BUILD_NUM" >> $GITHUB_OUTPUT🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/release.yml around lines 68 - 73, The current build number extraction in the build_number job uses a fragile grep -m1 for CURRENT_PROJECT_VERSION which can pick up commented or unrelated occurrences; update the BUILD_NUM extraction to match only the assignment line and ignore comments (e.g., restrict the pattern to lines where CURRENT_PROJECT_VERSION appears as a key, not inside comments, or anchor to the left of the line), replace the existing grep/sed pipeline that sets BUILD_NUM with a more precise shell pipeline (still writing the result to $GITHUB_OUTPUT as build_num) so it only captures the actual CURRENT_PROJECT_VERSION assignment and fails noisily if none is found.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/release.yml:
- Around line 68-73: The current build number extraction in the build_number job
uses a fragile grep -m1 for CURRENT_PROJECT_VERSION which can pick up commented
or unrelated occurrences; update the BUILD_NUM extraction to match only the
assignment line and ignore comments (e.g., restrict the pattern to lines where
CURRENT_PROJECT_VERSION appears as a key, not inside comments, or anchor to the
left of the line), replace the existing grep/sed pipeline that sets BUILD_NUM
with a more precise shell pipeline (still writing the result to $GITHUB_OUTPUT
as build_num) so it only captures the actual CURRENT_PROJECT_VERSION assignment
and fails noisily if none is found.
Remove empty sparkle:edSignature attribute from appcast.xml to fix update verification error.
Bump version to 1.3.4 (build 9).
Summary by CodeRabbit
发布说明