Type and paginate group members#6
Merged
Merged
Conversation
terjekv
force-pushed
the
agent/type-group-members
branch
from
July 23, 2026 11:55
16b3540 to
d594d0a
Compare
terjekv
force-pushed
the
agent/type-group-members
branch
from
July 25, 2026 00:33
d594d0a to
a42fd38
Compare
terjekv
marked this pull request as ready for review
July 25, 2026 00:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Hubuum v0.0.3 group-members endpoint is cursor-paginated and returns the
PrincipalMemberResponsecontract, but the client exposed raw dictionaries and silently converted any non-array response to[]. That hid malformed server responses and left membership pagination unavailable through the typed API.What changed
Principalshape with the exported, contract-completePrincipalMembermodelPrincipalMembervalues from synchronous and asynchronousgroups.members()members_page(),member_pages(), and boundedall_members()helpers with sync/async parityDecodeErrorVerification
uv sync --extra devuv run ruff format --check .uv run ruff check .(including active PLR0913)uv run mypyuv run bandit -q -r src scriptsuv run zizmor .uv run pytest --cov— 69 passed, 96.00% coverageuv run mkdocs build --strictuv buildThe local Docker daemon remained unresponsive even to
docker ps, so the pinned Hubuum v0.0.3 e2e workflow in CI is the live compatibility authority for this PR.Review focus
The public return type changes from dictionaries to frozen Pydantic values. This is intentional for the typed-client contract and is documented in the changelog.