Skip to content

Declare exportable workspace paths#501

Merged
jdchawla29 merged 1 commit into
mainfrom
codex/image-workspace-root
Jul 21, 2026
Merged

Declare exportable workspace paths#501
jdchawla29 merged 1 commit into
mainfrom
codex/image-workspace-root

Conversation

@jdchawla29

@jdchawla29 jdchawla29 commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • declare the workspace root on the existing filetracking/1 capability
  • exclude credential-shaped paths from the existing snapshot manifest

Why

Build introspection already calls setup and then snapshot. The platform builder only needs the declared root and export-safe path set to copy the post-setup workspace from the built image into its immutable S3 prefix.

The SDK does not upload file bytes, add an export path, change hashing semantics, or introduce another transfer protocol.

Validation

  • uv run ruff format --check hud/environment/file_tracker.py hud/environment/workspace.py hud/environment/tests/test_capability_backing.py hud/environment/tests/test_file_tracker.py
  • uv run ruff check hud/environment/file_tracker.py hud/environment/workspace.py hud/environment/tests/test_capability_backing.py hud/environment/tests/test_file_tracker.py
  • uv run pyright hud/environment/file_tracker.py hud/environment/workspace.py
  • uv run pytest hud/environment/tests -q — 74 passed

Note

Low Risk
Manifest and capability metadata changes only; tightens secret exclusion and adds a declared root path with no auth or RPC behavior changes in this diff.

Overview
Post-setup workspace manifests no longer list credential-shaped paths: FileTracker.current_manifest() skips entries marked redacted, so a snapshot RPC returns only verifiable, non-secret files (paths, sizes, hashes). Secret files remain in the tracker for change detection and redacted diffs, but they are not published as manifest rows.

The filetracking/1 capability now includes the semantic workspace root (resolved POSIX path) in params, alongside setup_diff, so platform builders can locate the tracked tree on the host without inferring it from SSH cwd alone.

Tests lock in an empty manifest when only .env exists at baseline, and expect the served capability params to include root.

Reviewed by Cursor Bugbot for commit df3e243. Bugbot is set up for automated code reviews on this repo. Configure here.

@jdchawla29
jdchawla29 marked this pull request as ready for review July 21, 2026 07:49

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f71e190308

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread hud/environment/file_tracker.py Outdated
Comment thread hud/environment/file_tracker.py Outdated
Comment thread hud/environment/file_tracker.py Outdated
@jdchawla29
jdchawla29 force-pushed the codex/image-workspace-root branch from f71e190 to 278c800 Compare July 21, 2026 08:05
@jdchawla29
jdchawla29 marked this pull request as draft July 21, 2026 08:06

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 278c80079b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread hud/environment/file_tracker.py Outdated
Comment thread hud/environment/file_tracker.py Outdated
Comment thread hud/environment/file_tracker.py Outdated
@jdchawla29
jdchawla29 marked this pull request as ready for review July 21, 2026 08:09

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 278c80079b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread hud/environment/file_tracker.py Outdated
@jdchawla29
jdchawla29 force-pushed the codex/image-workspace-root branch from 278c800 to 82e4d9a Compare July 21, 2026 08:22
@jdchawla29
jdchawla29 marked this pull request as draft July 21, 2026 08:22
Comment thread hud/environment/file_tracker.py Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 82e4d9a438

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread hud/environment/file_tracker.py Outdated
@jdchawla29
jdchawla29 force-pushed the codex/image-workspace-root branch from 82e4d9a to 8a7e234 Compare July 21, 2026 08:25
@jdchawla29
jdchawla29 marked this pull request as ready for review July 21, 2026 08:25

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8a7e234f65

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread hud/environment/file_tracker.py Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8a7e234. Configure here.

Comment thread hud/environment/file_tracker.py Outdated
@jdchawla29
jdchawla29 force-pushed the codex/image-workspace-root branch from 8a7e234 to df3e243 Compare July 21, 2026 08:46
@jdchawla29 jdchawla29 changed the title Expose post-setup workspace manifests Declare exportable workspace paths Jul 21, 2026
@jdchawla29
jdchawla29 merged commit 3aa7953 into main Jul 21, 2026
9 checks passed
@jdchawla29
jdchawla29 deleted the codex/image-workspace-root branch July 24, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant