bug: fsdp cannot load optimizor state using dcp#3904
Merged
SunMarc merged 1 commit intohuggingface:mainfrom Jan 12, 2026
Merged
bug: fsdp cannot load optimizor state using dcp#3904SunMarc merged 1 commit intohuggingface:mainfrom
SunMarc merged 1 commit intohuggingface:mainfrom
Conversation
SunMarc
reviewed
Jan 9, 2026
Member
SunMarc
left a comment
There was a problem hiding this comment.
Thanks ! Can you add a test to check that it works ?
Contributor
Author
|
I am not familiar with how testing system works. Could anyone else offer some help? The logic should be straightforward. Before this PR, nothing would be loaded from the optimizer checkpoint. |
Member
|
It's fine, we will rework on the tests at some point ! Code looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (3896) partially. Fix bug when using dcp, the optimizor state cannot be loaded. Tested with fsdp2.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@SunMarc