Skip to content

fix: pop unexpected argument before initializing empty parameter#3943

Closed
cynricfu wants to merge 1 commit into
huggingface:mainfrom
cynricfu:fix_unexpected_is_hf_initialized_argument
Closed

fix: pop unexpected argument before initializing empty parameter#3943
cynricfu wants to merge 1 commit into
huggingface:mainfrom
cynricfu:fix_unexpected_is_hf_initialized_argument

Conversation

@cynricfu
Copy link
Copy Markdown

What does this PR do?

A simple fix for this issue from the transformers repo.

This fix simply pops the _is_hf_initialized argument before initializing the empty parameter.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@cynricfu
Copy link
Copy Markdown
Author

@SunMarc In this fix, I simply pop the unexpected _is_hf_initialized argument from the kwargs dict. Will this affect other places?

Copy link
Copy Markdown
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix is fine but this is a bit troublesome to remove it when recrate a param in general. I will check what can we done upstream instead of having to deal with this in many other places

@SunMarc SunMarc closed this Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants