fix: pop unexpected argument before initializing empty parameter#3943
Closed
cynricfu wants to merge 1 commit into
Closed
fix: pop unexpected argument before initializing empty parameter#3943cynricfu wants to merge 1 commit into
cynricfu wants to merge 1 commit into
Conversation
Author
|
@SunMarc In this fix, I simply pop the unexpected |
SunMarc
reviewed
Feb 27, 2026
Member
SunMarc
left a comment
There was a problem hiding this comment.
This fix is fine but this is a bit troublesome to remove it when recrate a param in general. I will check what can we done upstream instead of having to deal with this in many other places
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A simple fix for this issue from the transformers repo.
This fix simply pops the
_is_hf_initializedargument before initializing the empty parameter.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.