add on_main_process decorators

[ZhiyuanChen]

#366

[HuggingFaceDocBuilderDev]

The documentation is not available anymore as the PR was closed or merged.

[sgugger]

Thanks for your PR! I think it would be great to have those as methods of the Accelerator object (your code refers to a `self`` that does not exist otherwise).

[ZhiyuanChen]

Hi @sgugger , sorry for the delay, hope this is better now

[muellerzr]

@ZhiyuanChen could you run "make style; make quality" to solve the Quality Check issue? 😃

Thanks!

[ZhiyuanChen]

@ZhiyuanChen could you run "make style; make quality" to solve the Quality Check issue? 😃

Thanks!

Sorry, I thought I have fixed it but somehow didn't pushed...

[sgugger]

Thanks a lot for iterating! Almost ready to merge, I just left some comments on the docstrings and a suggestion to group the decorators on_process and on_local_process together. Let me know your thoughts!

[sgugger]

Suggested change

	def on_process(process_idx):
	def on_process(process_idx, local=False):

Maybe we could group this one and the text in one decorator since it's one that takes arguments?

[ZhiyuanChen]

Thanks a lot for iterating! Almost ready to merge, I just left some comments on the docstrings and a suggestion to group the decorators on_process and on_local_process together. Let me know your thoughts!

Thank you very much tor your comments and suggestion.

For the docstrings, i have accepted rll suggestions.

For the group... I think its rather important to ensure api in a similar organisation, and grouping in this way break the consistency with is_local_main_process and on_local_main_process.
Though we could use alias/partial/impl to make the implementation more compact

[sgugger]

Let's roll with your choice and we'll see what users think then. We can always add aliases in the future :-)

Thanks again for your contribution!

[ZhiyuanChen]

Let's roll with your choice and we'll see what users think then. We can always add aliases in the future :-)

Haha, sure thing~

Thanks again for your contribution!

No worries~