Merged
Conversation
sgugger
commented
Aug 1, 2022
| """ | ||
|
|
||
| def __init__(self, dataset, split_batches: bool = False, **kwargs): | ||
| def __init__(self, dataset, split_batches: bool = False, _drop_last: bool = False, **kwargs): |
Collaborator
Author
There was a problem hiding this comment.
PyTorch does not let us pass drop_last.
Comment on lines
-503
to
-506
| if not self._stop_iteration: | ||
| yield batch | ||
| batch, batch_info, skip = next_batch, next_batch_info, next_skip | ||
| else: |
Collaborator
Author
There was a problem hiding this comment.
Removed this logic as we don't need to take the next batch to have an informed decision on whether we are the last batch or not. This was actually causing the dataloader to stop one batch too early.
|
The documentation is not available anymore as the PR was closed or merged. |
muellerzr
approved these changes
Aug 1, 2022
Contributor
muellerzr
left a comment
muellerzr
left a comment
There was a problem hiding this comment.
Thanks for iterating and working with me on this 🤗
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the dispatch dataloader which was a bit broken by the recent refactors. It's untested (since it requires a multiGPU setup) but will be in the new evaluation testing @muellerzr will add soon.