Skip to content

Fix multi-node issues and simplify param logic#627

Merged
muellerzr merged 2 commits intomainfrom
use_main
Aug 11, 2022
Merged

Fix multi-node issues and simplify param logic#627
muellerzr merged 2 commits intomainfrom
use_main

Conversation

@muellerzr
Copy link
Contributor

Fixes the multi-gpu logic raised here and also simplifies how args are setup for the namespace object

@muellerzr muellerzr added the bug Something isn't working label Aug 11, 2022
@muellerzr muellerzr requested a review from sgugger August 11, 2022 16:30
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 11, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@muellerzr muellerzr merged commit 010aa93 into main Aug 11, 2022
@muellerzr muellerzr deleted the use_main branch August 11, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants