Allow custom device placements for different objects#716
Merged
Conversation
muellerzr
approved these changes
Sep 23, 2022
Contributor
muellerzr
left a comment
muellerzr
left a comment
There was a problem hiding this comment.
Looks great! Thanks for this. One suggestion on the docstring for clarity but otherwise awesome!
sgugger
force-pushed
the
custom_device_placement
branch
from
7001191 to
4ece3e5
Compare
Co-authored-by: Zachary Mueller <muellerzr@gmail.com>
|
The documentation is not available anymore as the PR was closed or merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lets the user customize whether device_placement should be
TrueorFalsefor the different objects passed along to prepare. This feature was requested in #624Fixes #624