adding support to return logits and generate for Megatron-LM GPT models#819
Merged
pacman100 merged 7 commits intohuggingface:mainfrom Nov 8, 2022
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
reviewed
Nov 4, 2022
Collaborator
sgugger
left a comment
There was a problem hiding this comment.
Thanks for working on this! I think the generate method you are adding should be renamed to something including the name meagtron, otherwise we will confuse users that might expect to get the Transformers generate method and all it supports.
sgugger
approved these changes
Nov 7, 2022
sgugger
approved these changes
Nov 8, 2022
Collaborator
sgugger
left a comment
There was a problem hiding this comment.
Thanks for adding this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
megatron_generatemethod for Megatron-LM GPT model, this will use Tensor and Pipeline Parallelism to complete generations for a batch ofinputswhen using greedy with/without top_k/top_p sampling and for individual promptinputswhen using beam search decoding. Only a subset of features of transformersgenerateis supported. This will help in using large models via tensor and pipeline parallelism for generation (already does key-value caching and uses fused kernels by default).Below is the run of the example script megatron_gpt2_generation.py with the main parts of output logs given below: