Skip to content

Conversation

@CharlesCNorton
Copy link
Contributor

fix: correct grammar, usage, and article omissions in smolagents-can-see.md

  • Inserted the definite article "the" before references to "ReAct framework" and "singular MultiStepAgent class," ensuring proper article usage.

    • Rationale: “ReAct framework” and “singular MultiStepAgent class” are specific concepts, requiring “the” for clarity.
  • Fixed subject–verb agreement in the clause describing how variables and knowledge are incorporated into agent logs.

    • Rationale: Since “variables and knowledge” are plural, the verb must match that plurality.
  • Added the missing “d” in “defined above” (“define” → “defined”).

    • Rationale: Simple past participle form was needed for correct grammar.
  • Replaced “the glimpse” with “a glimpse” to fix article usage before a non-specific noun.

    • Rationale: “Glimpse” is an indefinite instance, so “a” is the more appropriate article.
  • Changed “looking forward to see” to “looking forward to seeing.”

    • Rationale: “Looking forward to” is followed by a gerund (“seeing”) rather than an infinitive.

"Woe to you, scribes of the keyboard and Pharisees of the syntax, for you tithe mint and dill and cumin but neglect the weightier matters of proofreading! Blind guides, straining out a gnat but swallowing a camel." (Matthew 23:23-24)

fix: correct grammar, usage, and article omissions in smolagents-can-see.md

- Inserted the definite article "the" before references to "ReAct framework" and "singular `MultiStepAgent` class," ensuring proper article usage.
  - Rationale: “ReAct framework” and “singular `MultiStepAgent` class” are specific concepts, requiring “the” for clarity.

- Fixed subject–verb agreement in the clause describing how variables and knowledge are incorporated into agent logs.
  - Rationale: Since “variables and knowledge” are plural, the verb must match that plurality.

- Added the missing “d” in “defined above” (“define” → “defined”).
  - Rationale: Simple past participle form was needed for correct grammar.

- Replaced “the glimpse” with “a glimpse” to fix article usage before a non-specific noun.
  - Rationale: “Glimpse” is an indefinite instance, so “a” is the more appropriate article.

- Changed “looking forward to see” to “looking forward to seeing.”
  - Rationale: “Looking forward to” is followed by a gerund (“seeing”) rather than an infinitive.

"Woe to you, scribes of the keyboard and Pharisees of the syntax, for you tithe mint and dill and cumin but neglect the weightier matters of proofreading! Blind guides, straining out a gnat but swallowing a camel."
(Matthew 23:23-24)
Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to fix all these, @CharlesCNorton! 🙌

cc @merveenoyan @andimarafioti

@pcuenca pcuenca merged commit 6f47108 into huggingface:main Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants