Skip to content

add mobile menu#64

Merged
Grsmto merged 22 commits into
mainfrom
mobile-menu
Apr 24, 2023
Merged

add mobile menu#64
Grsmto merged 22 commits into
mainfrom
mobile-menu

Conversation

@Grsmto
Copy link
Copy Markdown
Contributor

@Grsmto Grsmto commented Apr 21, 2023

  • Add super basic mobile menu for now

@Grsmto Grsmto requested a review from gary149 April 21, 2023 18:00
Comment thread src/lib/components/MobileNav.svelte Outdated
Comment thread src/lib/components/MobileNav.svelte Outdated
@Grsmto Grsmto requested a review from gary149 April 24, 2023 10:37
Comment thread src/lib/components/NavMenu.svelte Outdated
Comment thread src/lib/components/MobileNav.svelte Outdated
Copy link
Copy Markdown
Member

@coyotte508 coyotte508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise!

Comment thread src/lib/components/NavMenu.svelte Outdated
@Grsmto Grsmto merged commit 4dae10f into main Apr 24, 2023
@Grsmto Grsmto deleted the mobile-menu branch April 24, 2023 12:03
ice91 pushed a commit to ice91/chat-ui that referenced this pull request Oct 30, 2024
* add mobile menu

* fix

* Auto-naming convos by summarizing them (huggingface#58)

* Auto-naming convos by summarizing them

* Ok let's do it only on first message then

* revamp

* location.reload for now

* avoid huge titles

* fix messages width

* add community feedback to nav

* fix tokens keeping coming even when changing conversation (huggingface#62)

* favicon

* 🐛 Fix generating bug (huggingface#68)

* 🐛 Fix redirect after delete

* ✨ Remove endoftext (huggingface#70)

* 🐛 Remove sanitized < (huggingface#71)

* 🩹 Change 301 to 302 in case we want to use the route for something else

* 🩹 Use passed fetch cc @julien-c

When using @huggingface/infernece in the backend we'll need to make it support custom fetch as well

* refactor mobile menu + improve accessibility

* fix missing menu on md size + regression share button on hover

* fix chat title truncate on mobile

* fix layout max-width on mobile

* use a single event dispatcher instead of 2

* add missing type="button"

* remove duplicated wrapper after merge conflict

---------

Co-authored-by: Victor Mustar <victor.mustar@gmail.com>
Co-authored-by: Julien Chaumond <julien@huggingface.co>
Co-authored-by: Eliott C <coyotte508@gmail.com>
maksym-work pushed a commit to siilats/chat-ui that referenced this pull request Jul 2, 2025
* add mobile menu

* fix

* Auto-naming convos by summarizing them (huggingface#58)

* Auto-naming convos by summarizing them

* Ok let's do it only on first message then

* revamp

* location.reload for now

* avoid huge titles

* fix messages width

* add community feedback to nav

* fix tokens keeping coming even when changing conversation (huggingface#62)

* favicon

* 🐛 Fix generating bug (huggingface#68)

* 🐛 Fix redirect after delete

* ✨ Remove endoftext (huggingface#70)

* 🐛 Remove sanitized &lt; (huggingface#71)

* 🩹 Change 301 to 302 in case we want to use the route for something else

* 🩹 Use passed fetch cc @julien-c

When using @huggingface/infernece in the backend we'll need to make it support custom fetch as well

* refactor mobile menu + improve accessibility

* fix missing menu on md size + regression share button on hover

* fix chat title truncate on mobile

* fix layout max-width on mobile

* use a single event dispatcher instead of 2

* add missing type="button"

* remove duplicated wrapper after merge conflict

---------

Co-authored-by: Victor Mustar <victor.mustar@gmail.com>
Co-authored-by: Julien Chaumond <julien@huggingface.co>
Co-authored-by: Eliott C <coyotte508@gmail.com>
gary149 added a commit to gary149/chat-ui that referenced this pull request Aug 29, 2025
* add mobile menu

* fix

* Auto-naming convos by summarizing them (huggingface#58)

* Auto-naming convos by summarizing them

* Ok let's do it only on first message then

* revamp

* location.reload for now

* avoid huge titles

* fix messages width

* add community feedback to nav

* fix tokens keeping coming even when changing conversation (huggingface#62)

* favicon

* 🐛 Fix generating bug (huggingface#68)

* 🐛 Fix redirect after delete

* ✨ Remove endoftext (huggingface#70)

* 🐛 Remove sanitized &lt; (huggingface#71)

* 🩹 Change 301 to 302 in case we want to use the route for something else

* 🩹 Use passed fetch cc @julien-c

When using @huggingface/infernece in the backend we'll need to make it support custom fetch as well

* refactor mobile menu + improve accessibility

* fix missing menu on md size + regression share button on hover

* fix chat title truncate on mobile

* fix layout max-width on mobile

* use a single event dispatcher instead of 2

* add missing type="button"

* remove duplicated wrapper after merge conflict

---------

Co-authored-by: Victor Mustar <victor.mustar@gmail.com>
Co-authored-by: Julien Chaumond <julien@huggingface.co>
Co-authored-by: Eliott C <coyotte508@gmail.com>
gary149 added a commit to gary149/chat-ui that referenced this pull request Aug 29, 2025
* add mobile menu

* fix

* Auto-naming convos by summarizing them (huggingface#58)

* Auto-naming convos by summarizing them

* Ok let's do it only on first message then

* revamp

* location.reload for now

* avoid huge titles

* fix messages width

* add community feedback to nav

* fix tokens keeping coming even when changing conversation (huggingface#62)

* favicon

* 🐛 Fix generating bug (huggingface#68)

* 🐛 Fix redirect after delete

* ✨ Remove endoftext (huggingface#70)

* 🐛 Remove sanitized &lt; (huggingface#71)

* 🩹 Change 301 to 302 in case we want to use the route for something else

* 🩹 Use passed fetch cc @julien-c

When using @huggingface/infernece in the backend we'll need to make it support custom fetch as well

* refactor mobile menu + improve accessibility

* fix missing menu on md size + regression share button on hover

* fix chat title truncate on mobile

* fix layout max-width on mobile

* use a single event dispatcher instead of 2

* add missing type="button"

* remove duplicated wrapper after merge conflict

---------

Co-authored-by: Victor Mustar <victor.mustar@gmail.com>
Co-authored-by: Julien Chaumond <julien@huggingface.co>
Co-authored-by: Eliott C <coyotte508@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants