Missing docs in multiple diffusers/models files

[a-r-r-o-w]

Multiple classes such as this in the models directory are missing documentation or an explanation for what the different parameters mean, and sometimes type hints. Has it been done this way by choice to allow for a clean and direct code view? if not, I would be happy to take this up as an issue and write the docs.

[sayakpaul]

I think it was on purpose in some sense because these blocks are usually modified to accommodate different features. But maybe @patrickvonplaten can shed more light!

[patrickvonplaten]

Hey @a-r-r-o-w,

Good point! Actually it would be amazing if all these blocks would have better type hints and doc strings - we simply forgot to add those when the library was created

[a-r-r-o-w]

Got it @patrickvonplaten! Will work on this and open a PR as soon as possible 🚀

[a-r-r-o-w]

Hey @patrickvonplaten. After making changes to multiple files and viewing the diff, I find it really difficult to go over and review the changes I've made to make sure they are correct, and I think it would feel the same for other reviewers. Should I open PRs one by one for the different files and would you like me to maintain a tracker for the different files like you did #287? This would also allow for other collaborators to open PRs with improvements on files that are yet to have type hints and docs added.

[DN6]

@a-r-r-o-w Go ahead and open smaller PRs for the type hints. And I can do a review.