Skip to content

Fix static typing and doc typos #8807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 8, 2024
Merged

Fix static typing and doc typos #8807

merged 2 commits into from
Jul 8, 2024

Conversation

@zhuoqun-chen
Copy link
Contributor

@zhuoqun-chen zhuoqun-chen commented Jul 8, 2024

What does this PR do?

Fixes typos:

  • 1 return type doc string typo in scheduling_ddim.py
  • 1 static type checking typo in scheduling_ddpm.py

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

a-r-r-o-w
a-r-r-o-w approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution! Looks correct to me, but might require a few minor changes in other files with make fix-copies

cc @sayakpaul

src/diffusers/schedulers/scheduling_ddpm.py
timestep_spacing: str = "leading",
steps_offset: int = 0,
rescale_betas_zero_snr: int = False,
rescale_betas_zero_snr: bool = False,
Copy link
Contributor

@a-r-r-o-w a-r-r-o-w Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might have to run make fix-copies to fix all instances of this type hint. If you find more inconsistencies, please feel free to open follow-up PRs!

Copy link
Contributor Author

@zhuoqun-chen zhuoqun-chen Jul 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @a-r-r-o-w for the information! I just make fix-copies and made a follow-up commit that corrects another file scheduling_ddpm_parallel.py.

@a-r-r-o-w a-r-r-o-w requested a review from yiyixuxu July 8, 2024 18:34
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 8, 2024

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@yiyixuxu yiyixuxu merged commit 70611a1 into huggingface:main Jul 8, 2024
@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Jul 8, 2024

thanks for your contribution!

@zhuoqun-chen
Copy link
Contributor Author

zhuoqun-chen commented Jul 8, 2024

Thank you @a-r-r-o-w and @yiyixuxu for reviewing and merging this PR! Have a nice day!

sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
@zhuoqun-chen @sayakpaul
Fix static typing and doc typos (#8807)
043d98f 
* Fix static typing and doc typos

* Fix more same type hint typos with make fix-copies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiyixuxu yiyixuxu Awaiting requested review from yiyixuxu

1 more reviewer

@a-r-r-o-w a-r-r-o-w a-r-r-o-w approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhuoqun-chen @HuggingFaceDocBuilderDev @yiyixuxu @a-r-r-o-w