Skip to content

Conversation

@sayakpaul
Copy link
Member

@sayakpaul sayakpaul requested a review from Wauplin October 15, 2024 04:44
Copy link
Collaborator

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

import pandas as pd
from huggingface_hub import hf_hub_download, upload_file
from huggingface_hub.utils._errors import EntryNotFoundError
from huggingface_hub.utils import EntryNotFoundError
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from huggingface_hub.utils import EntryNotFoundError
from huggingface_hub.errors import EntryNotFoundError

This should be even more future-proof (though it's already fine :) ).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It requires a library-wide change and I will prefer a separate PR for that.

@sayakpaul sayakpaul merged commit 99d8747 into main Oct 15, 2024
10 checks passed
@sayakpaul sayakpaul deleted the fix-benchmarks branch October 15, 2024 08:37
sayakpaul added a commit that referenced this pull request Dec 23, 2024
fix import of EntryNotFoundError.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants