Skip to content

[Chore] fix import of EntryNotFoundError. #9676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2024
Merged

[Chore] fix import of EntryNotFoundError. #9676

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac0c0ef
fix import of EntryNotFoundError.
sayakpaul Oct 15, 2024
4b6fd44
Merge branch 'main' into fix-benchmarks
sayakpaul Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmarks/push_results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

import pandas as pd
from huggingface_hub import hf_hub_download, upload_file
from huggingface_hub.utils._errors import EntryNotFoundError
from huggingface_hub.utils import EntryNotFoundError
Copy link
Collaborator

@Wauplin Wauplin Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from huggingface_hub.utils import EntryNotFoundError
from huggingface_hub.errors import EntryNotFoundError

This should be even more future-proof (though it's already fine :) ).

Copy link
Member Author

@sayakpaul sayakpaul Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It requires a library-wide change and I will prefer a separate PR for that.



sys.path.append(".")
Expand Down
Loading