Fix a dtype issue when evaluating the sana transformer with a float16 autocast context#10362
Open
Nerogar wants to merge 1 commit intohuggingface:mainfrom
Open
Fix a dtype issue when evaluating the sana transformer with a float16 autocast context#10362Nerogar wants to merge 1 commit intohuggingface:mainfrom
Nerogar wants to merge 1 commit intohuggingface:mainfrom
Conversation
Contributor
|
this probably will cause a torch compile graph break since it's inline in a compiled function. (upstream issue here) |
… autocast context
900cf7d to
3d013a8
Compare
Contributor
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
Contributor
Author
|
Bad bot. This is not an issue, it's a pull request that should be merged once the upstream issue in PyTorch is fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
the query, key and value tensors of the attention calculations are already converted to float32 format. But if an autocast context is active, intermediate values are still converted back to float16 precision. Disabling autocast in this region prevents this unwanted conversion. The result is then converted back to the original dtype afterwards.
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@lawrence-cj