[LoRA] add support for more Qwen LoRAs #12581
+6
−1
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -2213,6 +2213,10 @@ def convert_key(key: str) -> str: | |||||||||
|
|
||||||||||
| state_dict = {convert_key(k): v for k, v in state_dict.items()} | ||||||||||
|
|
||||||||||
| has_default = any("default." in k for k in state_dict) | ||||||||||
| if has_default: | ||||||||||
| state_dict = {k.replace("default.", ""): v for k, v in state_dict.items()} | ||||||||||
|
Comment on lines
+2217
to
+2218
There was a problem hiding this comment. So, that it's done as intended:
Suggested change
There was a problem hiding this comment. same comment as here - 'default' is not in the key's prefix, so this won't be the intended behavior in this case |
||||||||||
|
|
||||||||||
| converted_state_dict = {} | ||||||||||
| all_keys = list(state_dict.keys()) | ||||||||||
| down_key = ".lora_down.weight" | ||||||||||
|
|
||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4940,7 +4940,8 @@ def lora_state_dict( | |
| has_alphas_in_sd = any(k.endswith(".alpha") for k in state_dict) | ||
| has_lora_unet = any(k.startswith("lora_unet_") for k in state_dict) | ||
| has_diffusion_model = any(k.startswith("diffusion_model.") for k in state_dict) | ||
| has_default = any("default." in k for k in state_dict) | ||
|
There was a problem hiding this comment. same comment as #12581 (comment) - 'default' is not in the key's prefix, so this won't be the intended behavior in this case |
||
| if has_alphas_in_sd or has_lora_unet or has_diffusion_model or has_default: | ||
| state_dict = _convert_non_diffusers_qwen_lora_to_diffusers(state_dict) | ||
|
|
||
| out = (state_dict, metadata) if return_lora_metadata else state_dict | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's starting with "default.", then let's be explicit about that:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"default" isn't the prefix though, e.g.
transformer_blocks.0.attn.add_v_proj.lora_A.default.weight