[torchao] Fix record_stream with torchao and group offloading#13427
Closed
asomoza wants to merge 1 commit intofix-torchao-groupoffloadingfrom
Closed
[torchao] Fix record_stream with torchao and group offloading#13427asomoza wants to merge 1 commit intofix-torchao-groupoffloadingfrom
record_stream with torchao and group offloading#13427asomoza wants to merge 1 commit intofix-torchao-groupoffloadingfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
Author
|
I did a double check and this is not a correct fix, the VRAM usage jumps from 5.67 GB to 13.71GB |
Member
Author
|
actually, with the torchao PR this works ok, so closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the use of
record_streamwithtorchaoandgroup offload. Without this, the resulting image is wrong.Who can review?
@sayakpaul