Skip to content

Fix SanaTransformer2DModel crash when guidance_embeds=True with non-guidance pipelines #13517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ricardo-M-L wants to merge 1 commit into from
+13 −1
Closed

Fix SanaTransformer2DModel crash when guidance_embeds=True with non-guidance pipelines #13517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/diffusers/models/transformers/sana_transformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,19 @@ def forward(

hidden_states = self.patch_embed(hidden_states)

if guidance is not None:
# Dispatch on the embedding *type* rather than on whether `guidance` was
# passed: `SanaCombinedTimestepGuidanceEmbeddings` does not accept
# `batch_size`, and `AdaLayerNormSingle` does not accept `guidance`,
# so routing by input would silently misbehave when the model is built
# with `guidance_embeds=True` but the pipeline does not thread guidance
# through (e.g. SanaPipeline / SanaPAGPipeline — see #12540).
if isinstance(self.time_embed, SanaCombinedTimestepGuidanceEmbeddings):
if guidance is None:
raise ValueError(
"SanaTransformer2DModel was configured with `guidance_embeds=True`, but `guidance` "
"was not provided. Either pass `guidance` to the transformer or rebuild the model "
"with `guidance_embeds=False`."
)
timestep, embedded_timestep = self.time_embed(
timestep, guidance=guidance, hidden_dtype=hidden_states.dtype
)
Expand Down
Loading