Fix non-deterministic T5 outputs in HiDream pipeline tests#13534
Merged
DN6 merged 2 commits intohuggingface:mainfrom Apr 21, 2026
Merged
Fix non-deterministic T5 outputs in HiDream pipeline tests#13534DN6 merged 2 commits intohuggingface:mainfrom
DN6 merged 2 commits intohuggingface:mainfrom
Conversation
Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com>
Contributor
Author
|
@DN6 @sayakpaul pls help review, thx! |
Contributor
Author
|
The failed check are pre-existing and unrelated to this change. |
sayakpaul
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to fix 2 failed test cases for hiream pipeline tests:
Root cause: In
get_dummy_components(), T5EncoderModel(config) creates the model in training mode by default. The tiny-random-t5 config has dropout_rate=0.1, so each forward pass produces different embeddings due to active dropout — even undertorch.no_grad(). In production this isn't an issue becausefrom_pretrained()automatically calls.eval(), but we need to add this explicitly fortext_encoder_3in the test file