Skip to content

Fix FlaxLMS step timestep→index; complete get_lms_coefficient docs#13556

Open
HaoyuLi-Nova wants to merge 1 commit intohuggingface:mainfrom
HaoyuLi-Nova:main
Open

Fix FlaxLMS step timestep→index; complete get_lms_coefficient docs#13556
HaoyuLi-Nova wants to merge 1 commit intohuggingface:mainfrom
HaoyuLi-Nova:main

Conversation

@HaoyuLi-Nova
Copy link
Copy Markdown

@HaoyuLi-Nova HaoyuLi-Nova commented Apr 24, 2026

What does this PR do?

This PR fixes FlaxLMSDiscreteScheduler.step so it maps the timestep value passed from Flax pipelines (the label
stored in state.timesteps[i]) to a step index via jnp.where, consistent with FlaxEulerDiscreteScheduler and
with PyTorch LMSDiscreteScheduler (which uses step_index). It also adds prediction_type="sample" for parity
with the PyTorch scheduler, and completes get_lms_coefficient docstrings/types (including explicit float return).

No new runtime dependencies.

N/A (no tracking issue)

Before submitting

Who can review?

@yiyixuxu

@github-actions github-actions Bot added schedulers size/S PR with diff < 50 LOC labels Apr 24, 2026
@HaoyuLi-Nova HaoyuLi-Nova changed the title Replace the TODO placeholders in the docstring of Document FlaxLMSDiscreteScheduler.get_lms_coefficient arguments Apr 24, 2026
…ation and additional prediction type support. Updated docstrings for clarity and adjusted index handling for timesteps.
@HaoyuLi-Nova HaoyuLi-Nova reopened this Apr 24, 2026
@github-actions github-actions Bot added size/S PR with diff < 50 LOC and removed size/S PR with diff < 50 LOC labels Apr 24, 2026
@github-actions github-actions Bot added size/S PR with diff < 50 LOC and removed size/S PR with diff < 50 LOC labels Apr 24, 2026
@HaoyuLi-Nova HaoyuLi-Nova changed the title Document FlaxLMSDiscreteScheduler.get_lms_coefficient arguments Fix FlaxLMS step timestep→index; complete get_lms_coefficient docs Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

schedulers size/S PR with diff < 50 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant