Conversation
…pect patterns Distilled from the ErnieImage modular pipeline review (PR #13498): - New "Common modular conventions" section: skim qwenimage / flux2 / wan / helios first, mirroring the references-driven shape of models.md / pipelines.md. - Promoted "Standalone block reusability" to a Key pattern. Each block (text encoder, VAE encoder, prepare-latents, denoise, decoder) must run on its own; encoders take raw inputs only, per-prompt expansion happens in a dedicated input step inside the core denoise sequence. Replaces old gotchas #4 (pre-computed encoder outputs) and #5 (VAE encode in prepare-latents). - Promoted "Flat block assembly" to a Key pattern (was gotcha #7). - New gotcha "Respect the declared IO system": one rule covering three bypass directions — defensive `getattr` reads of declared components/state, undeclared `block_state` writes, and direct `state.set()` calls that skip `set_block_state` entirely. - Reworked InputParam/OutputParam section to link to INPUT_PARAM_TEMPLATES / OUTPUT_PARAM_TEMPLATES in modular_pipeline_utils.py (the registry is dynamic) and added a non-template example. - Added a distilled-checkpoint exception to the `guidance_scale`-as-input gotcha — distilled flux-style models legitimately accept it. - Dropped the "inputs duplicating derivable state" gotcha (uncommon). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.