schedulers/flow_match_euler_discrete: fix double-shift bug by storing sigma_min/sigma_max before shift is applied#13724
Closed
Dev-X25874 wants to merge 1 commit into
Conversation
…ma_min/sigma_max before shift is applied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #13243
FlowMatchEulerDiscreteScheduler.__init__was storingsigma_minandsigma_maxafter the shift formula had already been applied tosigmas:Then in
set_timesteps, when no custom sigmas/timesteps are provided, the scheduler reconstructs a linspace fromsigma_max→sigma_min(the shifted values), divides back bynum_train_timesteps, and applies the shift formula a second time — resulting in a doubly-shifted sigma schedule that diverges from what the model was trained with.This PR moves the
sigma_min/sigma_maxassignment to before the shift is applied, soset_timestepsalways starts from the correct unshifted linear range and applies the shift exactly once.The fix is surgical:
self.sigmasandself.timestepsstored in__init__are unchanged. Only the two boundary reference scalars are corrected. Users passing customsigmasortimestepsdirectly toset_timestepsare entirely unaffected.Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@yiyixuxu