Skip to content

[tests] refactor ltx2 autoencoder tests to use latest mixins#13739

Merged
sayakpaul merged 6 commits into
mainfrom
autoencoder-ltx-2-tests-refactor
May 14, 2026
Merged

[tests] refactor ltx2 autoencoder tests to use latest mixins#13739
sayakpaul merged 6 commits into
mainfrom
autoencoder-ltx-2-tests-refactor

Conversation

@sayakpaul
Copy link
Copy Markdown
Member

As the PR title says.

@sayakpaul sayakpaul requested a review from dg845 May 13, 2026 08:14
@github-actions github-actions Bot added tests size/M PR with diff < 200 LOC labels May 13, 2026
Copy link
Copy Markdown
Collaborator

@dg845 dg845 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! If I run the tests locally, the following tests fail for both the LTX-2.X video and audio VAEs (and on the CI):

  1. test_from_save_pretrained
  2. test_from_save_pretrained_variant
  3. test_determinism
  4. test_sharded_checkpoints_with_parallel_loading

Since test_determinism is one of the tests that fail, I wonder if the underlying non-determinism is also affecting the save-then-load tests as well.

I also see that the following tests fail locally (but not in the above CI run):

  1. test_sharded_checkpoints
  2. test_sharded_checkpoints_with_variant

Finally, the test_group_offloading_with_disk[leaf_level-False] test also fails locally for the LTX-2.X audio VAE, so it seems like it might have some offloading issues. Could you look into these test failures?

@sayakpaul
Copy link
Copy Markdown
Member Author

@dg845 thanks for testing, requested for a review a bit sooner. I think it's good now.

@sayakpaul sayakpaul requested a review from dg845 May 13, 2026 09:51
Copy link
Copy Markdown
Collaborator

@dg845 dg845 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I see that the TestAutoencoderKLLTX2AudioMemory::test_group_offloading_with_disk[leaf_level-False] test still fails locally for the LTX-2 audio VAE, do you think we should skip this particular test?

@dg845
Copy link
Copy Markdown
Collaborator

dg845 commented May 14, 2026

Actually, it seems like the LTX-2 audio VAE test_group_offloading_with_disk[leaf_level-False] is flaky, since sometimes it passes and sometimes it fails. Not sure why.

@sayakpaul
Copy link
Copy Markdown
Member Author

We can add is_flaky to the test to reflect that it's flaky?

@sayakpaul sayakpaul merged commit 8f14cde into main May 14, 2026
11 of 14 checks passed
@sayakpaul sayakpaul deleted the autoencoder-ltx-2-tests-refactor branch May 14, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M PR with diff < 200 LOC tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants