examples/dreambooth: fix missing weighting chunk when using prior preservation in Flux and SD3 LoRA training#13743
Open
Dev-X25874 wants to merge 2 commits into
Conversation
…target when using prior preservation (flux LoRA)
…target when using prior preservation (SD3 LoRA)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When
--with_prior_preservationis enabled, the training batch concatenatesinstance and class (prior) samples, so every per-sample tensor —
model_pred,target,sigmas, and thereforeweighting— has shape(2 * train_batch_size, ...).Inside the loss block,
model_predandtargetare correctly split viatorch.chunk(..., 2, dim=0), butweightingwas never chunked. This means:weighting(size2B) is broadcast againstmodel_pred_priorandtarget_prior(sizeB), producing a loss tensor of the wrong shape andapplying incorrectly paired timestep weights to the prior loss term.
weightinginstead of only the instance-sample half.
The correct pattern already exists in
train_dreambooth_lora_flux2.py:This PR applies the same fix to
train_dreambooth_lora_flux.pyandtrain_dreambooth_lora_sd3.py, which were both missing it.Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sayakpaul