schedulers/scheduling_dpmsolver_multistep: round timesteps for exponential and beta sigma schedules#13768
Open
Dev-X25874 wants to merge 1 commit into
Conversation
…ntial and beta sigma schedules
419797d to
5c83f8b
Compare
Contributor
Author
|
Hey @DN6 — could you please take a look at this PR when you get a chance? It fixes a silent off-by-one error in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In
DPMSolverMultistepScheduler.set_timesteps, theuse_karras_sigmasanduse_lu_lambdasbranches both calltimesteps.round()after computingtimesteps via
_sigma_to_t(which returns floating-point values throughinterpolation), before those timesteps are cast to
torch.int64.The
use_exponential_sigmasanduse_beta_sigmasbranches were missing this.round()call, causing raw float values to be truncated (not rounded) onthe
torch.int64cast at the end ofset_timesteps. This silently introducesa systematic off-by-one error in the noise schedule index lookup whenever
either of these two sigma modes is used with this scheduler.
This PR adds
timesteps = timesteps.round()to both branches, consistent withthe existing pattern already established by
use_karras_sigmasanduse_lu_lambdas.Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@DN6