fix the bug on the leading time schedule#13868
Open
TheLovesOfLadyPurple wants to merge 1 commit into
Open
Conversation
Author
|
If necessary, you can also add a breakpoint on line 1031 in the file src/diffusers/pipelines/stable_diffusion/pipeline_stable_diffusion.py to check it. It's actually very possible that other multi-step solver also has such a problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When the current UniPC Multistep Scheduler call the set_timesteps, it would not generate the correct leading time schedule. To be more explicitly, if you input different num_inference_steps when you call this function, it will generate different first timestep at the beginning of the inference. However, user will expect the first step is fixed on 999.
Fixes # input different num_inference_steps to the set_timesteps of the UniPC scheduler would generated different start time step.
We fix this bug on the UniPC Multistep Scheduler. Now the first inference step is fixed to 999. We write a simple test code and ensure that the first step of the inference is correct.
Who can review?
@yiyixuxu