Skip to content

fix inpainting pipeline when providing initial latents #3641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrickvonplaten merged 2 commits into from
Jun 2, 2023
Merged

fix inpainting pipeline when providing initial latents #3641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc364db
fix latents
Jun 1, 2023
b899228
fix copies
Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/diffusers/pipelines/controlnet/pipeline_controlnet_inpaint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -868,8 +868,8 @@ def prepare_latents(
# if pure noise then scale the initial latents by the Scheduler's init sigma
latents = latents * self.scheduler.init_noise_sigma if is_strength_max else latents
else:
latents = latents.to(device)
latents = latents * self.scheduler.init_noise_sigma
noise = latents.to(device)
latents = noise * self.scheduler.init_noise_sigma
Comment on lines +871 to +872
Copy link
Copy Markdown
Member

@sayakpaul sayakpaul Jun 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First the latents are being assigned as noise and then they're being assigned as latents. I find this exchange somewhat confusing. Could we change that?

Copy link
Copy Markdown
Contributor

@patrickvonplaten patrickvonplaten Jun 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm ok for me since that's the first time latents is seen


outputs = (latents,)

Expand Down
4 changes: 2 additions & 2 deletions src/diffusers/pipelines/stable_diffusion/pipeline_stable_diffusion_inpaint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,8 +653,8 @@ def prepare_latents(
# if pure noise then scale the initial latents by the Scheduler's init sigma
latents = latents * self.scheduler.init_noise_sigma if is_strength_max else latents
else:
latents = latents.to(device)
latents = latents * self.scheduler.init_noise_sigma
noise = latents.to(device)
latents = noise * self.scheduler.init_noise_sigma

outputs = (latents,)

Expand Down