fix a bug in inpaint pipeline when use regular text2image unet #5033
Merged
patrickvonplaten merged 4 commits intomainfrom Sep 18, 2023
Merged
fix a bug in inpaint pipeline when use regular text2image unet #5033patrickvonplaten merged 4 commits intomainfrom
patrickvonplaten merged 4 commits intomainfrom
Conversation
added 2 commits
September 14, 2023 08:26
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
|
Thanks for the fix, can you also double-check if other pipelines need to be updated? E.g. controlnet inpainting and SDXL inpainting |
patrickvonplaten
approved these changes
Sep 15, 2023
Contributor
patrickvonplaten
left a comment
There was a problem hiding this comment.
Let's also please add one fast test :-)
Contributor
|
Tests is flaky, let's merge |
Contributor
|
Is this merged onto main 😁 ? |
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
…ngface#5033) * fix * fix num_images_per_prompt >1 * other pipelines * add fast tests for inpaint pipelines --------- Co-authored-by: yiyixuxu <yixu310@gmail,com>
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…ngface#5033) * fix * fix num_images_per_prompt >1 * other pipelines * add fast tests for inpaint pipelines --------- Co-authored-by: yiyixuxu <yixu310@gmail,com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug reported here #4854
The issue comes from this line of code here - when we use inpainting pipeline with a regular text-to-image unet with 4 channels, it will only use the first image when given more than one image inputs.
diffusers/src/diffusers/pipelines/stable_diffusion/pipeline_stable_diffusion_inpaint.py
Line 1002 in 19edca8
I'm not sure if there is a reason it was currently done this way though.
This code currently fails but will be fixed in this PR