Fixes for Float16 inference Fast CUDA Tests #5097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return super().test_save_load_optional_components() | ||
|
|
||
| def test_float16_inference(self): | ||
| super().test_float16_inference(expected_max_diff=1.0) |
Contributor
There was a problem hiding this comment.
Suggested change
| super().test_float16_inference(expected_max_diff=1.0) | |
| ... |
think values can not have a higher diff than 1.0 so this test is a bit moot I think. Let's maybe just skip it.
| return super().test_save_load_optional_components() | ||
|
|
||
| def test_float16_inference(self): | ||
| super().test_float16_inference(expected_max_diff=1.0) |
Contributor
There was a problem hiding this comment.
Suggested change
| super().test_float16_inference(expected_max_diff=1.0) | |
| ... |
think values can not have a higher diff than 1.0 so this test is a bit moot I think. Let's maybe just skip it.
patrickvonplaten
approved these changes
Sep 19, 2023
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* wip * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There are ~31 failing
test_float16_inferencetests in the the slow test runner. This PR fixes the flakiness issues.Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.