Skip to content

Conversation

@DN6
Copy link
Collaborator

@DN6 DN6 commented Sep 22, 2023

What does this PR do?

Compile tests fail with the following error when running with Python 3.8

This PR

  1. Adds a require_python39_or_higher decorator to mark compile tests
  2. Adds a new Dockerfile to build a dedicated docker image pytorch-compile-cuda to run the tests
  3. Updates the push test runners to run separate compile tests.

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

run: |
python -m pytest -n 1 --max-worker-restart=0 --dist=loadfile \
-s -v -k "not Flax and not Onnx" \
-s -v -k "not Flax and not Onnx and not compile" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for now, but let's maybe later make this a bit cleaner with ENV flag "@is_flax_available() @uses_torch_compile` ...

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@DN6 DN6 merged commit bdd2544 into main Sep 26, 2023
@kashif kashif deleted the tests-compile-fixes branch September 29, 2023 11:39
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
* test fix

* fix tests

* fix report name

---------

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* test fix

* fix tests

* fix report name

---------

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants