Skip to content

Conversation

@noskill
Copy link
Contributor

@noskill noskill commented Sep 25, 2023

In StableDiffusionControlNetPipeline constructor controlnet has type Union[ControlNetModel, List[ControlNetModel], Tuple[ControlNetModel], MultiControlNetModel] so such case should throw an exception

@patrickvonplaten
Copy link
Contributor

Hey @noskill,

Could you please add a reproducible code snippet that shows the current error ?

@noskill
Copy link
Contributor Author

noskill commented Sep 26, 2023

@patrickvonplaten minimal example:

from diffusers import ControlNetModel, StableDiffusionControlNetPipeline


model_id = "realismEngine/realismEngine_v10.safetensors"
cnet_id = "DionTimmer/controlnet_qrcode-control_v1p_sd15"

cnets = [ControlNetModel.from_pretrained(cnet_id)]
StableDiffusionControlNetPipeline.from_single_file(model_id, controlnet=cnets)

@patrickvonplaten
Copy link
Contributor

I see! Indeed that's a very nice fix - thank you :-)

@patrickvonplaten patrickvonplaten merged commit c7e0895 into huggingface:main Oct 4, 2023
chuzhdontcode pushed a commit to chuzhdontcode/diffusers that referenced this pull request Oct 4, 2023
* handle case when controlnet is list

* Update src/diffusers/loaders.py

* Apply suggestions from code review

* Update src/diffusers/loaders.py

* typecheck comment

---------

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
* handle case when controlnet is list

* Update src/diffusers/loaders.py

* Apply suggestions from code review

* Update src/diffusers/loaders.py

* typecheck comment

---------

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
@noskill noskill deleted the patch-2 branch April 10, 2024 05:41
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* handle case when controlnet is list

* Update src/diffusers/loaders.py

* Apply suggestions from code review

* Update src/diffusers/loaders.py

* typecheck comment

---------

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants