Fixed constants.py not using hugging face hub environment variable #5222
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@patrickvonplaten this one seems like a low-hanging fruit for next release |
| SAFETENSORS_WEIGHTS_NAME = "diffusion_pytorch_model.safetensors" | ||
| ONNX_EXTERNAL_WEIGHTS_NAME = "weights.pb" | ||
| HUGGINGFACE_CO_RESOLVE_ENDPOINT = "https://huggingface.co" | ||
| HUGGINGFACE_CO_RESOLVE_ENDPOINT = os.environ.get("HF_ENDPOINT", "https://huggingface.co") |
Contributor
There was a problem hiding this comment.
Yes that's in line with Transformers: https://github.com/huggingface/transformers/blob/1b8decb04c246ec8e1c4ba7f2749043d0876d24e/src/transformers/utils/hub.py#L124
Contributor
|
Thanks for the fix! |
chuzhdontcode
pushed a commit
to chuzhdontcode/diffusers
that referenced
this pull request
Oct 4, 2023
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes constants.py not using HF_ENDPOINT environment variable
Encountered this issue today, i was expecting to be able to connect to my custom HF_ENDPOINT repository however the diffusers repo did not have this functionality (https://huggingface.co/docs/huggingface_hub/package_reference/environment_variables) .
As most hugging face repositories already have this functionality, i did not update the documentation (https://github.com/search?q=org%3Ahuggingface%20HF_ENDPOINT&type=code)
My current fix was to use sed in my docker image workflow, which is not optimal if the filename/location changes. Not sure who to tag, but as the title is pretty self explanatory and the fix trivial i expect most people can pick it up.