Add a docstring for the AutoencoderKL's encode #5239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I tried to reuse as much as possible the style and contents of the |
patrickvonplaten
approved these changes
Oct 2, 2023
Contributor
patrickvonplaten
left a comment
patrickvonplaten
left a comment
There was a problem hiding this comment.
Looks great to me ❤️
sayakpaul
approved these changes
Oct 2, 2023
Member
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
LGTM but we need the tests to pass here. Could you please run make style && make quality?
Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
Contributor
Author
|
Ran |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Contributor
|
Failing tests are unrelated - merging! |
chuzhdontcode
pushed a commit
to chuzhdontcode/diffusers
that referenced
this pull request
Oct 4, 2023
* Add docstring for the AutoencoderKL's encode huggingface#5229 * Support Python 3.8 syntax in AutoencoderKL.decode type hints Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com> * Follow the style guidelines in AutoencoderKL's encode huggingface#5230 --------- Co-authored-by: stano <> Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* Add docstring for the AutoencoderKL's encode huggingface#5229 * Support Python 3.8 syntax in AutoencoderKL.decode type hints Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com> * Follow the style guidelines in AutoencoderKL's encode huggingface#5230 --------- Co-authored-by: stano <> Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* Add docstring for the AutoencoderKL's encode huggingface#5229 * Support Python 3.8 syntax in AutoencoderKL.decode type hints Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com> * Follow the style guidelines in AutoencoderKL's encode huggingface#5230 --------- Co-authored-by: stano <> Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5229