[Schedulers] Fix callback steps #5261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
approved these changes
Oct 2, 2023
Contributor
|
@patrickvonplaten the test is failing because the order of the elements have changed |
Contributor
Author
Yeah, I don't think it's related |
patrickvonplaten
force-pushed
the
fix_callback_steps
branch
from
33e3679 to
7e5b17f
Compare
yiyixuxu
approved these changes
Oct 2, 2023
|
The documentation is not available anymore as the PR was closed or merged. |
chuzhdontcode
pushed a commit
to chuzhdontcode/diffusers
that referenced
this pull request
Oct 4, 2023
* fix all * make fix copies * make fix copies
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* fix all * make fix copies * make fix copies
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* fix all * make fix copies * make fix copies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes: #5233
As figured out by @bghira, 2nd order schedulers are a bit special. In our case here we need to make sure that the passed callback_idx should account for this. This mass PR was created by running the following find and replace regex: