replace references to deprecated KeyArray & PRNGKeyArray #5324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for proposing this upstream, @jakevdp! 😄 |
pcuenca
approved these changes
Oct 8, 2023
Member
pcuenca
left a comment
pcuenca
left a comment
There was a problem hiding this comment.
Looks good to me, thanks a lot!
Would you recommend to start going over uses of jax.random.PRNGKey() and replacing them with jax.random.key() now?
Collaborator
|
@pcuenca Good to merge this? |
Member
|
Yes! Maybe @patrickvonplaten or @yiyixuxu would like to take a quick look. |
patrickvonplaten
approved these changes
Oct 9, 2023
Contributor
There was a problem hiding this comment.
Looks good to me! Happy to bump JAX here to 0.4!
Thanks a lot @jakevdp
Contributor
Author
|
Thanks! |
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct annotation for PRNG keys is
jax.Array(see JEP 9263). Note thatjax.random.KeyArrayhas always been effectively aliased toAnyat type checking time, so changing these tojax.Arraymakes the annotations more specific than they were previously.I updated the version pinning to
jax>=0.4.1(released December 2022) because this is the first release wherejax.Arraywas available as a type annotation.