-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New xformers test runner #5349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New xformers test runner #5349
Conversation
| env: | ||
| HUGGING_FACE_HUB_TOKEN: ${{ secrets.HUGGING_FACE_HUB_TOKEN }} | ||
| run: | | ||
| python -m pytest -n 1 --max-worker-restart=0 --dist=loadfile -s -v -k "xformers" --make-reports=tests_torch_xformers_cuda tests/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| python -m pytest -n 1 --max-worker-restart=0 --dist=loadfile -s -v -k "xformers" --make-reports=tests_torch_xformers_cuda tests/ | |
| python -m pytest -n 1 --max-worker-restart=0 --dist=loadfile -s -v -k "xformers" --make-reports=tests_torch_xformers_cuda tests/ |
ok for now, but I'm not a huge fan of using the -k "xformers" option in our runners as this is quite brittle. I'd prefer to start marking the tests like we do in Transformers: https://github.com/huggingface/transformers/blob/1e3c9ddacc7fc4142253bc9ddcba85c4d5b977e7/tests/test_modeling_common.py#L2746 so that we can then run:
pytest -m xformers tests/....
| omegaconf \ | ||
| pytorch-lightning \ | ||
| xformers | ||
| pytorch-lightning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually why do we have pytorch-lightning in here? We never use this library IMO. Can we remove it from all places in the dockers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. I'll make the change.
* move xformers to dedicated runner * fix * remove ptl from test runner images
What does this PR do?
xformers breaks cuDNN drivers with torch 2.1. This PR
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.