Skip to content

Conversation

@linjiapro
Copy link
Contributor

@linjiapro linjiapro commented Oct 13, 2023

What does this PR do?

Original size of image will be passed into SDXL pipeline. The order of it should be width, height according to StableDiffusionXLPipeline, but the training script has it in the order of height, width. This PR fixes that.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@linjiapro
Copy link
Contributor Author

cc @siriuscdk

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

Could you maybe propagate this change to the other scripts as well?

Thanks very much in advance :-)

@linjiapro
Copy link
Contributor Author

@sayakpaul
I have found another file needs edit, already get it done.

What will be the next step? Do I click "Update branch" button to get it merged into the branch?

@sayakpaul
Copy link
Member

Thanks for your help. Once the CI is green, I am happy to merge it.

@patrickvonplaten patrickvonplaten merged commit 45db049 into huggingface:main Oct 18, 2023
mhetrerajat pushed a commit to mhetrerajat/diffusers that referenced this pull request Oct 23, 2023
…cript (huggingface#5382)

* wip

* wip

---------

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
@gtebbutt
Copy link

gtebbutt commented Nov 1, 2023

I've been chasing down an issue in my own training code and came across this commit - I wanted to double check if there might be an error here, since as far as I can see the pipeline code and original paper both use (h, w) ordering?

@patrickvonplaten
Copy link
Contributor

I've been chasing down an issue in my own training code and came across this commit - I wanted to double check if there might be an error here, since as far as I can see the pipeline code and original paper both use (h, w) ordering?

You're 100% correct! We need to be more careful here going forward and always double-check (cc @sayakpaul )

patrickvonplaten added a commit that referenced this pull request Nov 1, 2023
…aining script" (#5614)

Revert "Fix the order of width and height of original size in SDXL training script (#5382)"

This reverts commit 45db049.
kashif pushed a commit to kashif/diffusers that referenced this pull request Nov 11, 2023
…aining script" (huggingface#5614)

Revert "Fix the order of width and height of original size in SDXL training script (huggingface#5382)"

This reverts commit 45db049.
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
…cript (huggingface#5382)

* wip

* wip

---------

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
…aining script" (huggingface#5614)

Revert "Fix the order of width and height of original size in SDXL training script (huggingface#5382)"

This reverts commit 45db049.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants