-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Fix the order of width and height of original size in SDXL training script #5382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the order of width and height of original size in SDXL training script #5382
Conversation
|
cc @siriuscdk |
sayakpaul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much!
Could you maybe propagate this change to the other scripts as well?
Thanks very much in advance :-)
|
@sayakpaul What will be the next step? Do I click "Update branch" button to get it merged into the branch? |
|
Thanks for your help. Once the CI is green, I am happy to merge it. |
…cript (huggingface#5382) * wip * wip --------- Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
|
I've been chasing down an issue in my own training code and came across this commit - I wanted to double check if there might be an error here, since as far as I can see the pipeline code and original paper both use |
You're 100% correct! We need to be more careful here going forward and always double-check (cc @sayakpaul ) |
…aining script" (huggingface#5614) Revert "Fix the order of width and height of original size in SDXL training script (huggingface#5382)" This reverts commit 45db049.
…cript (huggingface#5382) * wip * wip --------- Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
…aining script" (huggingface#5614) Revert "Fix the order of width and height of original size in SDXL training script (huggingface#5382)" This reverts commit 45db049.
What does this PR do?
Original size of image will be passed into SDXL pipeline. The order of it should be width, height according to StableDiffusionXLPipeline, but the training script has it in the order of height, width. This PR fixes that.
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.