Japanese docs #5478
Merged
Japanese docs #5478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevhliu
reviewed
Oct 23, 2023
Member
stevhliu
left a comment
stevhliu
left a comment
There was a problem hiding this comment.
Nice work! 👏
You'll also need to modify the build_documentation.yml and build_pr_documentation.yml file to include the language code for Japanese (ja) to build the docs.
Contributor
Author
|
@stevhliu Thanks for the review! And should be fixed |
stevhliu
approved these changes
Oct 23, 2023
Member
stevhliu
left a comment
stevhliu
left a comment
There was a problem hiding this comment.
Thanks for the changes, just two minor ones remaining :)
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
Author
|
@stevhliu Forgot to say but should be done! Fixed the folder name to jp->ja too |
Member
|
Thanks again for your contribution! 🤗 |
kashif
pushed a commit
to kashif/diffusers
that referenced
this pull request
Nov 11, 2023
* Finished _toctree.yml and index.md * Finished installation.md * Properly finished installation.md and almost finished quicktour * Finished quicktour * Finished stable diffusion doc * Fixed _toctree.yml * Fixed requests * Fix country code * Properly push
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* Finished _toctree.yml and index.md * Finished installation.md * Properly finished installation.md and almost finished quicktour * Finished quicktour * Finished stable diffusion doc * Fixed _toctree.yml * Fixed requests * Fix country code * Properly push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds Japanese documentations
Fixes #5285
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
Since, it's the docs, also @stevhliu and @yiyixuxu